Fix sharing of typed arrays from constructor#1483
Merged
Merged
Conversation
AThousandShips
added
bug
AThousandShips
removed
the
waiting for Godot
AThousandShips
marked this pull request as ready for review
June 6, 2024 14:42
Collaborator
|
Thanks! I think I'd prefer to wait until the Godot PR is merged first, because that'll mean the approach has gotten review from folks who understand this code better than me. :-) |
|
This PR fixes an issue with TypedArrays duplicating when retrieved from dictionaries #1508 with the official Godot 4.2.2-stable engine. |
dsnopek
approved these changes
Jun 26, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me! Just waiting on the Godot PR getting merged in order to merge this.
Collaborator
|
Cherry-picked for 4.2 in PR #1527 |
Collaborator
|
Cherry-picked for 4.1 in PR #1529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
Doesn't depend on the engine fix beyond approval of the approach, so if it looks good for this side I'm open for it being merged here first (only the compatibility expectations to consider)