Skip to content

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API.#1479

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
bruvzg:ts_gde_sync_cpp
Jun 13, 2024
Merged

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API.#1479
dsnopek merged 1 commit into
godotengine:masterfrom
bruvzg:ts_gde_sync_cpp

Conversation

@bruvzg

@bruvzg bruvzg commented Jun 3, 2024

Copy link
Copy Markdown
Member

@bruvzg bruvzg added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Jun 3, 2024
@bruvzg bruvzg added this to the 4.x milestone Jun 3, 2024
@bruvzg
bruvzg force-pushed the ts_gde_sync_cpp branch from 3c5ed43 to 639466f Compare June 3, 2024 04:52
@AThousandShips AThousandShips added the waiting for Godot PRs that can't be merged until an engine PR is merged first label Jun 3, 2024
@bruvzg
bruvzg force-pushed the ts_gde_sync_cpp branch from 639466f to e4f1fc2 Compare June 11, 2024 05:40
@dsnopek

dsnopek commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

@bruvzg Now that the Godot PR is merged, could you please rebase this and take it out of draft? It also needs the updates to the gdextension_interface.h that were made later (adding @deprecated). Thanks!

…xpose new/changed low-level methods to GDExtension API.
@bruvzg
bruvzg force-pushed the ts_gde_sync_cpp branch from e4f1fc2 to 2360f84 Compare June 13, 2024 15:57
@bruvzg
bruvzg marked this pull request as ready for review June 13, 2024 16:20
@bruvzg
bruvzg requested a review from a team as a code owner June 13, 2024 16:20

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek
dsnopek merged commit 9f6fe36 into godotengine:master Jun 13, 2024
@aaronfranke

Copy link
Copy Markdown
Member

When I compile on the latest Godot master and the latest godot-cpp master on macOS, I get this error:

Compiling addons/secondext/src/godot-cpp/src/classes/low_level.cpp ...
addons/secondext/src/godot-cpp/src/classes/low_level.cpp:59:17: error: out-of-line definition of 'ptrw' does not match any declaration in 'godot::Image'
uint8_t *Image::ptrw() {
                ^~~~
addons/secondext/src/godot-cpp/src/classes/low_level.cpp:63:23: error: out-of-line definition of 'ptr' does not match any declaration in 'godot::Image'
const uint8_t *Image::ptr() {
                      ^~~
2 errors generated.
scons: *** [addons/secondext/src/godot-cpp/src/classes/low_level.macos.template_debug.universal.o] Error 1

@dsnopek

dsnopek commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Does the generated image.hpp have the ptr() and ptrw() methods? It's sounds like maybe it didn't get re-generated after the update?

@aaronfranke

Copy link
Copy Markdown
Member

@dsnopek Apologies, it was a case of a bad cache / lack of regeneration. I tried nuking the generated files and compiling again and it worked.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation waiting for Godot PRs that can't be merged until an engine PR is merged first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants