Fix warnings emitted with -Wall#1478
Merged
Merged
Conversation
Member
|
These are valid changes generally but more generally we don't necessarily support building with every possible warning setting, so any future niche errors that might be fired by a setting we don't have as part of our build setup might not be as appropriate, though again in this case they should be valid |
Closed
dsnopek
approved these changes
Jun 10, 2024
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! These changes look good to me.
Collaborator
|
Cherry-picked for 4.1 in PR #1491 |
Collaborator
|
Cherry-picked for 4.2 in PR #1492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am tracking 4.2 branch of godot-cpp for my project and compiling my whole project with -Wall. I recently updated godot-cpp to pull all changes from 4.2 branch and there are some new warnings during build that this PR fixes.
The warnings that are fixed by this are:
The first two are just changing the int type to match the one on right hand side and the third one is just what gcc suggested.