Update free_property_list callback to take count#1450
Merged
Conversation
dsnopek
added
the
enhancement
dsnopek
marked this pull request as draft
April 26, 2024 18:41
AThousandShips
added
the
waiting for Godot
raulsntos
reviewed
Apr 26, 2024
dsnopek
force-pushed
the
free-property-list-count
branch
from
April 26, 2024 18:55
348c718 to
563ee30
Compare
dsnopek
force-pushed
the
free-property-list-count
branch
from
April 30, 2024 13:48
563ee30 to
8cc78cf
Compare
dsnopek
marked this pull request as ready for review
April 30, 2024 13:49
Collaborator
Author
|
Since PR godotengine/godot#91179 is now merged, I've taken this out of draft. And I've also taken this opportunity to remove the comment about the |
dsnopek
removed
the
waiting for Godot
akien-mga
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for changes in PR godotengine/godot#91179
Note: This doesn't change how we handle properties using the count, it sticks with the same old approach.
Keeping this as a draft until that PR is merged