Implement to/from dict helpers for PropertyInfo/MethodInfo#1443
Merged
Conversation
Naros
force-pushed
the
property-method-dict-helpers
branch
2 times, most recently
from
April 19, 2024 19:26
baadca7 to
78bebbd
Compare
Naros
force-pushed
the
property-method-dict-helpers
branch
from
April 20, 2024 22:50
78bebbd to
2a041b5
Compare
dsnopek
approved these changes
Apr 23, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good to me :-)
This code appears to match the implementations of the same methods in Godot itself.
AThousandShips
added
enhancement
Collaborator
|
Cherry-picked for 4.2 in PR #1465 |
Collaborator
|
Cherry-picked for 4.1 in PR #1466 |
|
Found an unexpected bug caused by the override Dictionary operator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Others may appreciate these rather than create their own implementations.