Skip to content

Fix PropertyInfo to use hint/usage default constants#1440

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
Naros:propertyinfo-wrong-usage-init-value
Apr 17, 2024
Merged

Fix PropertyInfo to use hint/usage default constants#1440
dsnopek merged 1 commit into
godotengine:masterfrom
Naros:propertyinfo-wrong-usage-init-value

Conversation

@Naros

@Naros Naros commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

This seems to stem from the old property usage flags before they were adjusted in 2022. It's probably just best to init the value using the PROPERTY_USAGE_DEFAULT to avoid this in the future.

@Naros
Naros requested a review from a team as a code owner April 16, 2024 04:03
Comment thread include/godot_cpp/core/property_info.hpp Outdated
@AThousandShips AThousandShips added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Apr 16, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 16, 2024
@Naros
Naros force-pushed the propertyinfo-wrong-usage-init-value branch from 601fdc1 to e160966 Compare April 16, 2024 11:25
@Naros Naros changed the title Fix incorrect PropertyInfo usage default Fix PropertyInfo to use hint/usage default constants Apr 16, 2024

@AThousandShips AThousandShips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsnopek
dsnopek merged commit ad307e4 into godotengine:master Apr 17, 2024
@dsnopek

dsnopek commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Thanks!

@dsnopek

dsnopek commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.1 in PR #1441

@dsnopek

dsnopek commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.2 in PR #1442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants