Skip to content

Use GDREGISTER defines in example#1435

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
Repiteo:example-use-defines
Apr 11, 2024
Merged

Use GDREGISTER defines in example#1435
dsnopek merged 1 commit into
godotengine:masterfrom
Repiteo:example-use-defines

Conversation

@Repiteo

@Repiteo Repiteo commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

Converts the direct use of class registration functions to their equivalent GDREGISTER defines.

@Repiteo
Repiteo requested a review from a team as a code owner April 10, 2024 18:52
@dsnopek

dsnopek commented Apr 10, 2024

Copy link
Copy Markdown
Collaborator

Thanks!

I've wanted to make this change for so long. :-)

While you're in there, can you update the example in the README.md too?

@Repiteo
Repiteo force-pushed the example-use-defines branch from 09c7fea to a537b4a Compare April 10, 2024 19:15

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek
dsnopek merged commit 4b7661a into godotengine:master Apr 11, 2024
@dsnopek dsnopek added cherrypick:4.1 cherrypick:4.2 enhancement This is an enhancement on the current functionality documentation and removed cherrypick:4.1 labels Apr 17, 2024
@dsnopek

dsnopek commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.1 in PR #1441

@dsnopek

dsnopek commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.2 in PR #1442

@Repiteo
Repiteo deleted the example-use-defines branch June 24, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants