Change cmake required to v3.13#1417
Merged
Merged
Conversation
AThousandShips
added
enhancement
ytnuf
marked this pull request as draft
March 22, 2024 12:59
This is because target_link_options was added in v3.13 So this wouldn't build with cmake v3.12 Likewise in CMAKE_CXX_STANDARD only supports value of 17 starting with cmake v3.9 So the test wouldn't build properly with cmake v3.6
ytnuf
marked this pull request as ready for review
March 22, 2024 13:56
Calinou
approved these changes
Mar 24, 2024
Calinou
left a comment
Calinou
left a comment
Member
There was a problem hiding this comment.
Ubuntu 20.04 has CMake 3.16, so this shouldn't affect the ability to build extensions on the oldest still-supported Ubuntu LTS as of writing.
Collaborator
|
Thanks! |
Collaborator
|
Cherry-picked for 4.1 in PR #1411 |
Collaborator
|
Cherry-picked for 4.2 in PR #1410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because target_link_options was added in v3.13 So this wouldn't build with cmake v3.12
https://cmake.org/cmake/help/latest/release/3.13.html#commands
Likewise in CMAKE_CXX_STANDARD only supports value of 17 starting with cmake v3.9
So the test wouldn't build properly with cmake v3.6