Skip to content

Add extension support for argument count to ScriptInstance#1413

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
AThousandShips:the_angry_count_extended_cpp
Apr 2, 2024
Merged

Add extension support for argument count to ScriptInstance#1413
dsnopek merged 1 commit into
godotengine:masterfrom
AThousandShips:the_angry_count_extended_cpp

Conversation

@AThousandShips

@AThousandShips AThousandShips commented Mar 14, 2024

Copy link
Copy Markdown
Member

@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality waiting for Godot PRs that can't be merged until an engine PR is merged first topic:gdextension This relates to the new Godot 4 extension implementation labels Mar 14, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 14, 2024
@AThousandShips AThousandShips removed the waiting for Godot PRs that can't be merged until an engine PR is merged first label Mar 14, 2024
@AThousandShips
AThousandShips marked this pull request as ready for review March 14, 2024 21:38
@AThousandShips
AThousandShips requested a review from a team as a code owner March 14, 2024 21:38
dsnopek
dsnopek approved these changes Apr 2, 2024
View reviewed changes

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek
dsnopek merged commit 3715bfe into godotengine:master Apr 2, 2024
@AThousandShips

AThousandShips commented Apr 2, 2024

Copy link
Copy Markdown
Member Author

Thank you!

@AThousandShips
AThousandShips deleted the the_angry_count_extended_cpp branch April 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

2 participants

@AThousandShips @dsnopek