Fix _notification() with parent and child classes#1381
Merged
Conversation
dsnopek
added
bug
dsnopek
force-pushed
the
notification-hierarchy
branch
from
February 22, 2024 20:46
d213d6f to
23c0109
Compare
AThousandShips
approved these changes
Mar 5, 2024
AThousandShips
left a comment
AThousandShips
left a comment
Member
There was a problem hiding this comment.
LGTM, matches the way it works in the engine
Collaborator
Author
|
Cherry-picked for 4.2 in PR #1410 |
Collaborator
Author
|
Cherry-picked for 4.1 in PR #1411 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you have a parent and child class both defined in GDExtension, and the child class has it's own
_notification()method, the parent_notification()won't be called. But, also, godot-cpp is not respecting thep_reversedflag, and will always run reversed, calling the child before the parent.This PR fixes that!
It also adds an automated test to ensure that it is working correctly, and so we won't break this again.