Implement verbose toggle from godot repo#1364
Merged
Merged
Conversation
Calinou
added
the
enhancement
dsnopek
reviewed
Apr 9, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
I'm personally in support of doing this, however:
- It would be nice to copy-paste the
no_verbose()function from Godot, so that we can easily keep Godot and godot-cpp in sync in the future - This needs to be rebased - there are conflicts now
Contributor
Author
|
Rebased & reimplemented! The function is 99% the same, with the exception of just grabbing |
dsnopek
approved these changes
Apr 10, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks great to me :-)
Collaborator
|
Cherry-picked for 4.1 in PR #1441 |
Collaborator
|
Cherry-picked for 4.2 in PR #1442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings over the
verboseenvironment variable from the main godot repo. Much like the main repo, it's disabled by default & enabling it will output logs identical to how they currently output. By leaving verbosity disabled, the outputs are significantly trimmed down, which causes a very real performance boost in certain environments (eg: running the build command via a VSCode task). Verbosity is enabled for GitHub Actions, both to mirror the godot repo & because those should be giving explicit output.