Skip to content

Update README.md with basic pre-requisites#1354

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
nightblade9:patch-1
Jan 11, 2024
Merged

Update README.md with basic pre-requisites#1354
akien-mga merged 1 commit into
godotengine:masterfrom
nightblade9:patch-1

Conversation

@nightblade9

Copy link
Copy Markdown
Contributor

No description provided.

@nightblade9
nightblade9 requested a review from a team as a code owner January 7, 2024 23:53
@YuriSizov

YuriSizov commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

Thanks for your contribution! Instead of an ad hoc suggestion in the readme, it's worth it to link to the Godot buildsystem documentation that already explains how to install scons on each supported platform:

https://docs.godotengine.org/en/stable/contributing/development/compiling/index.html

@nightblade9

Copy link
Copy Markdown
Contributor Author

Thanks, I wasn't aware of this (I'm not a C/C++ developer). I also wasn't aware that godot-cpp has the same build requirements as the editor. I'll update my PR momentarily.

@YuriSizov

Copy link
Copy Markdown
Contributor

I also wasn't aware that godot-cpp has the same build requirements as the editor.

I'm not sure it has exactly the same requirements, but as far as installing scons, engine's docs are already very comprehensive and should be more suitable than a short mention like your original edit was.

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In my experience, the pre-requisites are basically the same. So, I think this note makes sense!

@nightblade9

Copy link
Copy Markdown
Contributor Author

Thank you! I hope this will make it easier for more non-C++ developers (like me) to get into building GDExtensions!

Comment thread README.md Outdated
@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Jan 10, 2024
@akien-mga
akien-mga merged commit 0ddef6e into godotengine:master Jan 11, 2024
@akien-mga

Copy link
Copy Markdown
Member

Thanks! And congrats for your first merged godot-cpp contribution 🎉

@dsnopek

dsnopek commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picking to 4.2 in #1372

@dsnopek

dsnopek commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picking to 4.1 in #1373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants