Add missing OP_POWER operator to Variant#1349
Merged
Merged
Conversation
Contributor
|
Hi @AThousandShips I can confirm this will be okay in its current form and it does fix |
dsnopek
approved these changes
Jan 10, 2024
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Assuming I'm understanding this right, currently Variant::evaluate() is broken with all operators after OP_POWER because missing that item means the enum in godot-cpp doesn't line up with the enum in the GDExtension interface.
In any case, this change looks great to me :-)
akien-mga
approved these changes
Jan 11, 2024
Member
|
Thanks! |
Member
Author
|
Thank you! |
|
Yep, thanks! |
Collaborator
|
Cherry-picking to 4.2 in #1372 |
Collaborator
|
Cherry-picking to 4.1 in #1373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this breaks compatibility as there's no binary compatibility to maintain here, the mapping to the engine is done via the interface macros, but need verification here
Edit: This likely fixes
Variant::evaluatewhich tries to mapOperatortoGDExtensionVariantOperatorwhich doesn't line up