Fix expected argument count for call errors#1346
Merged
Merged
Conversation
AThousandShips
added
bug
dsnopek
approved these changes
Dec 30, 2023
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
The changes here appear to match the changes to binder_common.h in Godot. Looks good to me!
Collaborator
|
Cherry-picking to 4.2 in #1372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
godot-cpp version of:
Fix expected argument count for
Callablecall errors godot#80844Fixes: Confusing error message when signal calls callable with wrong number of arguments #1345
Cherry picking for 4.2 as it was merged in 4.2 but not for 4.1 to match the engine where it was not cherry picked for 4.1