Send NOTIFICATION_POSTINITIALIZE to extension classes#1321
Merged
Conversation
akien-mga
approved these changes
Nov 30, 2023
Member
|
Thanks! |
Collaborator
Author
|
Cherry-picking to 4.1 in #1373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1269
This turned out to be a little messier to implement than I had imagined, because in godot-cpp it's
Wrapped::_postinitialize()(rather than in Godot where it'sObject::_postinitialize()) so it's got to cast theWrapped *toObject *to send the notification. It's probably safe to assume that allWrapped *are in fact descended fromObject *, but I did adynamic_cast<Object *>()just to be sure.This PR includes tests that fail without the fix, and then succeed with it.