Allow registering "runtime classes"#1256
Merged
Merged
Conversation
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
placeholders
branch
from
February 13, 2024 14:51
2e0fb69 to
1ecd564
Compare
dsnopek
force-pushed
the
placeholders
branch
from
February 13, 2024 15:01
1ecd564 to
fb88457
Compare
dsnopek
changed the title
dsnopek
changed the title
akien-mga
approved these changes
Feb 20, 2024
akien-mga
left a comment
akien-mga
left a comment
Member
There was a problem hiding this comment.
Didn't review in depth nor test, but looks good at a glance.
deralmas
approved these changes
Feb 21, 2024
deralmas
left a comment
deralmas
left a comment
Member
There was a problem hiding this comment.
Just gave a quick look and things look fine!
Collaborator
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion to PR godotengine/godot#82554
NOTE: This won't pass tests until after the Godot PR is merged.
Fixes #1255
Fixes #709
Production edit: closes godotengine/godot-roadmap#36