Skip to content

Add functionality to pass custom files to the main SConstruct - #1212

Closed
adamscott wants to merge 1 commit into
godotengine:masterfrom
adamscott:add-customs-import
Closed

Add functionality to pass custom files to the main SConstruct#1212
adamscott wants to merge 1 commit into
godotengine:masterfrom
adamscott:add-customs-import

Conversation

@adamscott

Copy link
Copy Markdown
Member

Makes it possible for a project to use the godot-cpp SConstruct and still use locally a custom.py file.

Update the test project to pass a customs array to the main SConstruct.

@adamscott
adamscott requested a review from a team as a code owner August 15, 2023 17:21
@adamscott adamscott added this to the 4.x milestone Aug 15, 2023
@adamscott adamscott added the enhancement This is an enhancement on the current functionality label Aug 15, 2023
Makes it possible for a project to use the godot-cpp SConstruct and
still use locally a custom.py file.

Update the test project to pass a customs array to the main SConstruct.
@dsnopek

dsnopek commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

This PR seems very similar in purpose to PR #1196 but additionally includes some compilation db changes?

If this is just meant to be about "custom.py" then perhaps it'd make sense to close this PR and continue on the older one?

@adamscott

Copy link
Copy Markdown
Member Author

This PR seems very similar in purpose to PR #1196 but additionally includes some compilation db changes?

Sorry, my bad, that PR completely fell out of my mind.

If this is just meant to be about "custom.py" then perhaps it'd make sense to close this PR and continue on the older one?

Yes.

@adamscott adamscott closed this Aug 17, 2023
@akien-mga akien-mga removed this from the 4.x milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants