Implement typed dictionaries#1162
Merged
Merged
Conversation
Repiteo
marked this pull request as draft
July 3, 2023 18:27
Repiteo
force-pushed
the
typed-dictionary
branch
from
July 18, 2023 14:56
eec44d2 to
191037d
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
2 times, most recently
from
October 2, 2023 16:57
65f0881 to
f5b340a
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
from
September 6, 2024 15:44
f5b340a to
ebf275e
Compare
Repiteo
marked this pull request as ready for review
September 6, 2024 21:29
Repiteo
force-pushed
the
typed-dictionary
branch
3 times, most recently
from
September 17, 2024 17:39
2775b10 to
fd05eca
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
from
September 17, 2024 20:05
fd05eca to
2ffff66
Compare
dsnopek
added
the
enhancement
dsnopek
approved these changes
Sep 18, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good to me :-)
Zylann
reviewed
Sep 22, 2024
| return type_name | ||
|
|
||
|
|
||
| def correct_typed_dictionary(type_name): |
| fully_used_classes.add(dict_type_name) | ||
| else: | ||
| used_classes.add(dict_type_name) | ||
| dict_type_name = dict_type_names[2] |
Collaborator
There was a problem hiding this comment.
Why index 2? That would be the third entry. I think dictionary only have 2 types?
| fully_used_classes.add(dict_type_name) | ||
| else: | ||
| used_classes.add(dict_type_name) | ||
| dict_type_name = dict_type_names[2] |
Collaborator
There was a problem hiding this comment.
Why index 2? That would be the third entry. I think dictionary only have 2 types?
Collaborator
|
@Repiteo Any thoughts on Zylann's comments above? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A godot-cpp counterpart to PR godotengine/godot#78656
Tests/builds will fail until the above is merged, as this PR is dependant on it.