Skip to content

Fix incorrect memory allocation in release builds.#1053

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:fix_release_memalloc
Feb 21, 2023
Merged

Fix incorrect memory allocation in release builds.#1053
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:fix_release_memalloc

Conversation

@bruvzg

@bruvzg bruvzg commented Feb 21, 2023

Copy link
Copy Markdown
Member

Fixes #842

@bruvzg bruvzg added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Feb 21, 2023
@bruvzg bruvzg added this to the 4.0 milestone Feb 21, 2023
@bruvzg
bruvzg force-pushed the fix_release_memalloc branch 3 times, most recently from ff2d220 to a18b20f Compare February 21, 2023 12:15
@bruvzg
bruvzg marked this pull request as ready for review February 21, 2023 12:17
@bruvzg
bruvzg requested a review from a team as a code owner February 21, 2023 12:17
Co-authored-by: lightyears <lightyears1998@hotmail.com>
@bruvzg
bruvzg force-pushed the fix_release_memalloc branch from a18b20f to ba4b501 Compare February 21, 2023 13:32
@bruvzg
bruvzg requested a review from a team as a code owner February 21, 2023 13:32
@bruvzg

bruvzg commented Feb 21, 2023

Copy link
Copy Markdown
Member Author

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

Seems like CI config need an update. Changed it to 20.04

@akien-mga
akien-mga merged commit 2a15286 into godotengine:master Feb 21, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible heap corruption issue

2 participants