{cmake} Use the same compiler warnings as godot#1008
Merged
Conversation
asmaloney
force-pushed
the
cmake-compiler-warnings
branch
from
January 19, 2023 17:22
e7cce7b to
42834c0
Compare
asmaloney
marked this pull request as ready for review
January 19, 2023 17:42
asmaloney
force-pushed
the
cmake-compiler-warnings
branch
2 times, most recently
from
January 25, 2023 17:10
ad94d16 to
1b15da7
Compare
Contributor
Author
|
I don't know who's in the GDExtension review group, and I can't add reviewers in the UI, so pinging @akien-mga and @Faless for review. Thank you! |
asmaloney
force-pushed
the
cmake-compiler-warnings
branch
from
February 4, 2023 16:18
1b15da7 to
d081b4b
Compare
akien-mga
added
enhancement
akien-mga
approved these changes
Feb 7, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on compiler warnings based on the SConstruct file in godot.
Also adds
GODOT_CPP_WARNING_AS_ERRORoption to treat warnings as errors. This is turned ON when building godot-cpp on its own (e.g. CI), but defaults to OFF if godot-cpp is being included in another project.(CMake part of #999)