Skip to content

Fixed that gravatar doesn't updated at login sometimes#161

Merged
umputun merged 2 commits into
go-pkgz:masterfrom
JayDi85:master
May 22, 2023
Merged

Fixed that gravatar doesn't updated at login sometimes#161
umputun merged 2 commits into
go-pkgz:masterfrom
JayDi85:master

Conversation

@JayDi85
Copy link
Copy Markdown
Contributor

@JayDi85 JayDi85 commented May 1, 2023

Avatar image from gravatar must be updated on each user's login. But sometime it doesn't work. After research found a possible problem:

  • Current timeout for gravatar: 1 second. It's too low;
  • Current download times for gravatar images by API: 0.9 - 1.2 second.

PR increases a timeout from 1 to 5 seconds, so that must fix the problem.

@JayDi85 JayDi85 requested a review from umputun as a code owner May 1, 2023 20:00
@coveralls
Copy link
Copy Markdown

coveralls commented May 1, 2023

Pull Request Test Coverage Report for Build 5033786696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.736%

Totals Coverage Status
Change from base Build 5033763935: 0.0%
Covered Lines: 247
Relevant Lines: 258

💛 - Coveralls

@umputun umputun merged commit 7bd5669 into go-pkgz:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants