allow to use specific logrus level in the adaptor#962
Merged
Conversation
taraspos
force-pushed
the
logrus-level
branch
from
877a602 to
cc23620
Compare
ChrisHines
requested changes
Feb 21, 2020
Member
ChrisHines
left a comment
ChrisHines
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Happy to add this feature, but would like it implemented a bit differently, see inline comment below.
ChrisHines
requested changes
Feb 21, 2020
ChrisHines
requested changes
Feb 21, 2020
Member
ChrisHines
left a comment
ChrisHines
left a comment
There was a problem hiding this comment.
Thanks. It's getting closer. There are a couple more tweaks to make, though.
ChrisHines
requested changes
Feb 24, 2020
Member
ChrisHines
left a comment
ChrisHines
left a comment
There was a problem hiding this comment.
Nice updates.
Next, it would be nice to add something to the unit tests to verify the new feature works as intended.
Also, see my suggestion on the docs for WithLevel below.
ChrisHines
requested changes
Feb 27, 2020
Member
ChrisHines
left a comment
ChrisHines
left a comment
There was a problem hiding this comment.
Sorry for the delay reviewing this. It is looking pretty good, I just have one comment on the new test.
ChrisHines
reviewed
Feb 29, 2020
peterbourgon
reviewed
Mar 2, 2020
peterbourgon
reviewed
Mar 2, 2020
peterbourgon
reviewed
Mar 2, 2020
Contributor
Author
|
Sorry for the delay. Fixed! |
ChrisHines
approved these changes
Mar 10, 2020
Member
|
LGTM, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.