Skip to content

upgrade go 1.7 ctxhttp to req.WithContext#535

Merged
peterbourgon merged 1 commit into
go-kit:masterfrom
stanxii:master
May 25, 2017
Merged

upgrade go 1.7 ctxhttp to req.WithContext#535
peterbourgon merged 1 commit into
go-kit:masterfrom
stanxii:master

Conversation

@stanxii
Copy link
Copy Markdown

@stanxii stanxii commented May 25, 2017

Upgrage ctxhttp to go 1.7 Context.

@stanxii
Copy link
Copy Markdown
Author

stanxii commented May 25, 2017

why my local envierment go 1.8 go test is ok?
$ go test -v
=== RUN TestHTTPClient
--- PASS: TestHTTPClient (0.00s)
=== RUN TestHTTPClientBufferedStream
--- PASS: TestHTTPClientBufferedStream (0.00s)
=== RUN TestClientFinalizer
--- PASS: TestClientFinalizer (0.00s)
=== RUN TestEncodeJSONRequest
--- PASS: TestEncodeJSONRequest (0.01s)
=== RUN TestSetHeader
--- PASS: TestSetHeader (0.00s)
=== RUN TestSetContentType
--- PASS: TestSetContentType (0.00s)
=== RUN TestServerBadDecode
--- PASS: TestServerBadDecode (0.00s)
=== RUN TestServerBadEndpoint
--- PASS: TestServerBadEndpoint (0.00s)
=== RUN TestServerBadEncode
--- PASS: TestServerBadEncode (0.00s)
=== RUN TestServerErrorEncoder
--- PASS: TestServerErrorEncoder (0.00s)
=== RUN TestServerHappyPath
--- PASS: TestServerHappyPath (0.00s)
=== RUN TestMultipleServerBefore
--- PASS: TestMultipleServerBefore (0.00s)
=== RUN TestMultipleServerAfter
--- PASS: TestMultipleServerAfter (0.00s)
=== RUN TestServerFinalizer
--- PASS: TestServerFinalizer (0.00s)
=== RUN TestEncodeJSONResponse
--- PASS: TestEncodeJSONResponse (0.00s)
=== RUN TestEncodeNoContent
--- PASS: TestEncodeNoContent (0.00s)
=== RUN TestEnhancedError
--- PASS: TestEnhancedError (0.00s)
=== RUN ExamplePopulateRequestContext
--- PASS: ExamplePopulateRequestContext (0.00s)
PASS
ok github.com/stanxii/kit/transport/http 0.147s

@peterbourgon
Copy link
Copy Markdown
Member

Flaky test, fixed now. Thanks!

@peterbourgon peterbourgon merged commit 0012c63 into go-kit:master May 25, 2017
@stanxii
Copy link
Copy Markdown
Author

stanxii commented May 26, 2017

@peterbourgon You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants