IsTerminal does not properly detect MSYS2 terminals on Windows.

[ereOn]

The current implementation of IsTerminal for Windows does only detect when a Go program is running in cmd.exe but not when it is running in MSYS2 (that includes Git bash for Windows).

Adding support for such a terminal detection can easily be done (see this C implementation) and I am willing to do a PR for this if desired.

The change would be 100%-backward compatible and self-contained.

What do you think ?

[ereOn]

I added a PR (#485) that allows MSYS/Cygwin terminal detection, using the same strategy followed by Vim (the text editor).

Let me know what you think.

[ereOn]

@peterbourgon ping ?

[peterbourgon]

I have no Windows exposure or experience. @ChrisHines?

[ChrisHines]

I do have Windows here. I've been too busy the last couple of weeks to put time into this. I haven't forgotten and will get to it when I have time. Also, I want to sort out #482 first.

[ChrisHines]

Fixed by #501.

[ereOn]

@ChrisHines Isn't there a mistake ? I don't think this was addressed by #501 which only deals with passing through the file descriptor when a SyncWriter is used.

[ChrisHines]

Yeah, my mistake.

…

On Thu, Mar 23, 2017, 8:25 AM Julien Kauffmann ***@***.***> wrote: @ChrisHines <https://github.com/ChrisHines> Isn't there a mistake ? I don't think this was addresses by #501 <#501> which only deals with passing through the file descriptor when a SyncWriter is used. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#484 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAvZ-XG4m-eiwnzMOChGsjGuj4dReTSks5romScgaJpZM4MUff5> .

[ChrisHines]

Implemented in #485.