Add global config file support for SharedOptions#2207
Open
remique wants to merge 4 commits intogitui-org:masterfrom
Open
Add global config file support for SharedOptions#2207remique wants to merge 4 commits intogitui-org:masterfrom
remique wants to merge 4 commits intogitui-org:masterfrom
Conversation
Contributor
Author
|
Oh, I was surprised by builds not passing but I see that clippy::empty_docs has been added in |
amaanq
added a commit
to amaanq/gitui
that referenced
this pull request
Feb 18, 2026
If gitui can't find a local \`.git/gitui.ron\`, it now falls back to \`gitui.ron\` in the config directory (\`~/.config/gitui/\` by default). The config directory can be overridden with \`--config-dir\` / \`-c\` or the \`GITUI_CONFIG_DIR\` env var, which also affects where themes and key bindings are loaded from. Both \`OptionsData\` and \`DiffOptions\` now derive \`#[serde(default)]\` so partial configs (e.g. only setting \`diff.ignore_whitespace\`) work without needing every field present. Supersedes gitui-org#2207, fixes gitui-org#2140.
amaanq
added a commit
to amaanq/gitui
that referenced
this pull request
Feb 18, 2026
If gitui can't find a local `.git/gitui.ron`, it now falls back to `gitui.ron` in the config directory (`~/.config/gitui/` by default). The config directory can be overridden with `--config-dir` / `-c` or the `GITUI_CONFIG_DIR` env var, which also affects where themes and key bindings are loaded from. Both `OptionsData` and `DiffOptions` now derive `#[serde(default)]` so partial configs (e.g. only setting `diff.ignore_whitespace`) work without needing every field present. Supersedes gitui-org#2207, fixes gitui-org#2140.
amaanq
added a commit
to amaanq/gitui
that referenced
this pull request
Feb 18, 2026
If gitui can't find a local `.git/gitui.ron`, it now falls back to `gitui.ron` in the config directory (`~/.config/gitui/` by default). The config directory can be overridden with `--config-dir` / `-c` or the `GITUI_CONFIG_DIR` env var, which also affects where themes and key bindings are loaded from. Both `OptionsData` and `DiffOptions` now derive `#[serde(default)]` so partial configs (e.g. only setting `diff.ignore_whitespace`) work without needing every field present. Supersedes gitui-org#2207, fixes gitui-org#2140.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2140.
It changes the following:
$GITUI_HOME/gitui.ronI followed the checklist:
make checkwithout errorsAlso:
gituifile togitui.ronso that both global and local configs match. I hope that's okay.