Implement namespace lifecycle management and authentication resolver#163
Merged
Conversation
- Add GraphQL contract for namespace operations including creation, deletion, and querying. - Define data model for namespaces with attributes such as identifier, tier, and audit fields. - Create implementation plan outlining the architecture and integration with existing datastore. - Develop quickstart guide for local setup and usage of the namespace API. - Document research decisions regarding API surface, authorization strategy, and identifier uniqueness. - Specify feature requirements and success criteria for namespace management.
Closed
5 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92f154d88c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add GraphQL schema (namespace.graphqls) with NamespaceTier enum, Namespace type, create/delete mutations, and query operations - Extend Datastore interface and implement namespace CRUD on memdb and ScyllaDB backends (uuid PK, bigint timestamps) - Add InstrumentedDatastore wrappers for namespace operations - Implement service layer with identifier validation, reserved name checks, enterprise-tier admin gate, and ownership-based deletion guard - Wire auth middleware into Resolver struct; polish auth.resolvers.go - Add contract tests (11 cases) and service tests (17 cases) covering all 3 user stories (create, list/get, delete) - Update docs/architecture.md with namespace lifecycle section - Mark spec 009-api-namespaces as Closed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
newNamespace was constructing IDs as "ns-id-<8chars>" which is not a valid UUID. The ScyllaDB backend calls mustParseUUID on the ID field and panics on non-UUID strings. Fix by using newID() directly, matching the pattern used by newProduct/newCategory/newCollection helpers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Derive expiresAt from configured JWT duration via AuthMiddleware.GetTokenDuration() instead of hardcoding 24h; token lifetime now matches what was actually issued - Add GetTokenDuration() to AuthMiddleware, delegating to SessionManager - Use gqlerror.Errorf consistently in RefreshToken stub (was fmt.Errorf) - Update gitstore-admin/codegen.yml schema glob from *.graphql to *.graphqls to match the renamed shared schema files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.