Never add a vendored smmap directory to sys.path#102
Merged
Byron merged 1 commit intogitpython-developers:masterfrom Oct 20, 2023
Merged
Never add a vendored smmap directory to sys.path#102Byron merged 1 commit intogitpython-developers:masterfrom
Byron merged 1 commit intogitpython-developers:masterfrom
Conversation
This removes the logic that appended the git submodule directory for smmap to sys.path under most circumstances when the version of gitdb was not from PyPI. Now gitdb does not modify sys.path. See gitpython-developers/GitPython#1717 and gitpython-developers/GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.
This was referenced Oct 20, 2023
Byron
approved these changes
Oct 20, 2023
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for tackling this 🙏!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the logic that appended the git submodule directory for
smmaptosys.pathunder most circumstances when the version ofgitdbwas not from PyPI. Nowgitdbdoes not modifysys.path.See GitPython#1717 and GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.
Please note that this does not make any documentation changes (and the changes in #103 are not related to this).