Fix incomplete typehinting for PathLike#1474
Merged
Byron merged 4 commits intogitpython-developers:mainfrom Aug 8, 2022
madebylydia:master
Merged
Fix incomplete typehinting for PathLike#1474Byron merged 4 commits intogitpython-developers:mainfrom madebylydia:master
Byron merged 4 commits intogitpython-developers:mainfrom
madebylydia:master
Conversation
Contributor
Author
Member
|
Thanks for adding Maybe this PR can be re-run occasionally to see if that fixes it as it should pull the latest version and fixed version of flake at some point. I also asked @Yobmod for assistance, maybe they have seen this issue before. |
Contributor
Author
|
Hello, please do not merge this PR as it appears the current fix might not
be correct.
As per the current fix, Pylance/mypy will complain that a str object does
not comply with the type hint. I assume it would be the same error raised
if I pass a byte object, but complaining it's not a str this time, I assume.
I need to investigate and see what else I can do, but this might be tricky.
…On Mon, Aug 1, 2022, 02:51 Sebastian Thiel ***@***.***> wrote:
Thanks for adding bytes, in theory it *should* now be ready. I myself am
not sure what's going on with flake8 except that it's probably buggy in the
latest version.
Maybe this PR can be re-run occasionally to see if that fixes it as it
should pull the latest version and fixed version of flake at some point.
—
Reply to this email directly, view it on GitHub
<#1474 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOSDPZ3QOGJQ3SPPBXZ7INDVW4NSDANCNFSM55FN4VFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
added 2 commits
August 7, 2022 18:31
Signed-off-by: Predeactor <predeactor0@gmail.com>
Signed-off-by: Predeactor <predeactor0@gmail.com>
Member
|
Thanks a lot for figuring this out with me! |
Contributor
Author
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds a more rich type hinting for the
git.types.PathLikeclass.Closes #1473.
Also remove unused imports in this file.