feat(ir): add typed helper for DockerInstaller@0#1015
Merged
jamesadevine merged 1 commit intoJun 15, 2026
Conversation
Add `docker_installer_step(docker_version)` factory function to
`src/compile/ir/tasks.rs` and replace the two hand-crafted
`TaskStep::new("DockerInstaller@0", ...)` call sites in
`src/compile/agentic_pipeline.rs` with the new typed helper.
The `dockerVersion` input is required by the task; the optional
`releaseType` input (default: `stable`) remains available via
`.with_input()`. Three unit tests cover the required-input path,
the optional-input path, and version string flexibility.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
Jun 15, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed factory function for
DockerInstaller@0to the ado-aw IR and eliminates two hand-craftedTaskStep::new(...)call sites in the compiler.Motivation
DockerInstaller@0is emitted in two places insrc/compile/agentic_pipeline.rs(the Agent job and the Detection job) using rawTaskStep::new("DockerInstaller@0", "Install Docker").with_input("dockerVersion", "26.1.4"). This PR introduces a well-typed helper that makes the required/optional input boundary explicit and removes the duplication.Changes
src/compile/ir/tasks.rs:docker_installer_step(docker_version)factory function with full doc comment and three unit testssrc/compile/agentic_pipeline.rs: bothTaskStep::new("DockerInstaller@0", ...)call sites replaced withdocker_installer_step("26.1.4"); unusedTaskStepimport removedADO Task Reference
DockerInstaller@0dockerVersion(string, e.g."26.1.4")releaseType(string, default"stable"; values:stable,edge,test,nightly)Validation
cargo build --all-targetscargo test— 1856 unit tests + all integration tests passcargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.