Add owning user to pull_request_count labels#65
Closed
j6s wants to merge 1 commit intogithubexporter:masterfrom
Closed
Add owning user to pull_request_count labels#65j6s wants to merge 1 commit intogithubexporter:masterfrom
j6s wants to merge 1 commit intogithubexporter:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #30
I have noticed, that if multiple users (or orgs) share a repository with the same name, then the
pull_request_countmetrics will cause an error while collecting metrics because the same metric has already been collected. In most cases this is because one user has forked the repo of another user.I have fixed this by adding the owning users name to the labels of the metric. While this solves the problem, it only makes a bit of sense since the number of pull requests of both repositories will always be the same. causing small amounts of duplicate data to be reported.