fix: handle repos with the same name in multiple orgs#63
Closed
js-timbirkett wants to merge 1 commit intogithubexporter:masterfrom
Closed
fix: handle repos with the same name in multiple orgs#63js-timbirkett wants to merge 1 commit intogithubexporter:masterfrom
js-timbirkett wants to merge 1 commit intogithubexporter:masterfrom
Conversation
Contributor
|
@henrymcconville could we merge this PR and prepare a release 🙏 ? Some users reported problems with dashboards not showing data properly because of this. Thanks! |
Collaborator
|
Hi @marctc, sorry for the delay in looking at this. It looks like tests are failing due to the change. @js-timbirkett would you be able to fix tests and repush? Thanks. |
Contributor
|
@henrymcconville thanks for fast response! I believe we only have to include this change: grafana@728d3fd#diff-64e0e8b52676edfdd08d95b45d8b7e4bf06e985eb16c607757a7ff696de86bb5R45 |
Collaborator
|
@marctc if you could open a separate PR, that would be great and I'll get it reviewed ASAP. |
Contributor
|
@henrymcconville done #101! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
I found an issue with running this against multiple orgs that have repos with the same names. This was due to the pull request metric using only the repo name in its labels. Adding the owner fixes this.
Thanks,
Tim Birkett