feat(exporter): include Git tag as attribute for github_repo_release_downloads metrics#104
Merged
henrymcconville merged 1 commit intogithubexporter:masterfrom Mar 5, 2024
Conversation
…_downloads` metrics Signed-off-by: hainenber <dotronghai96@gmail.com>
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
github_repo_release_downloadsmetric only has thereleaseattribute, which could be sometimes a human-readable name. This PR includes the Git tag value as metric's attribute, which is usually semver'edPotentially fixes grafana/alloy#235