[CI only] Explicitly require logger to fix Concurrent-Ruby removing the dependency #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the "logger" gem to the Gemfile to address the removal of the dependency for Concurrent-Ruby in Rails 6.1.
- Added gem "logger" in the Gemfile with an inline comment for context.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Gemfile
Outdated
| gem "activerecord", "~> #{ENV['RAILS_VERSION'] || DEFAULT_RAILS_VERSION}" | ||
| end | ||
|
|
||
| gem "logger" # fix for Rails 6.1 + Concurrent-Ruby |
There was a problem hiding this comment.
Consider specifying a version constraint for the 'logger' gem to ensure compatibility in the future, similar to the other gems in the file.
Suggested change
| gem "logger" # fix for Rails 6.1 + Concurrent-Ruby | |
| gem "logger", "~> 1.4" # fix for Rails 6.1 + Concurrent-Ruby |
bensheldon
changed the title
bensheldon
changed the title
bensheldon
changed the title
bensheldon
changed the title
issyl0
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fix for
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)which happens because newer versions of Concurrent-Ruby removed a dependency on Logger but older versions of Rails aren't compatible with that.