Skip to content

Use find_by_sql instead of select_all and send(:instantiate) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhawthorn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use find_by_sql instead of select_all and send(:instantiate) #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597abcd
Use _load_from_sql instead of send(:instantiate)
jhawthorn Sep 23, 2021
8a06b48
Actually just use find_by_sql
jhawthorn Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/github/sql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,7 @@ def models(klass)
return @models if defined? @models
return [] if frozen?

# Use select_all to retrieve hashes for each row instead of arrays of values.
@models = connection.
select_all(query, "#{klass.name} Load via #{self.class.name}").
map { |record| klass.send :instantiate, record }
@models = klass.find_by_sql(query)

retrieve_found_row_count
freeze
Expand Down