Skip to content

fix: encode antigravity undocumented intent to break DDUw false-positive loop - #47876

Closed
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/doc-healer-fix-antigravity-engine-doc
Closed

fix: encode antigravity undocumented intent to break DDUw false-positive loop#47876
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/doc-healer-fix-antigravity-engine-doc

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

antigravity is production-registered but intentionally excluded from user-facing docs. Because that exclusion was purely social (maintainer PR closures), drift detectors had no machine-readable signal and kept re-filing the same engines.md gap — 13 duplicate issues in 7 days.

Go: pkg/workflow/

  • Engine interface — new IsUserFacingDocumented() bool method; default implementation on BaseEngine returns !undocumented (default true for all engines)
  • BaseEngine — new undocumented bool field; when true, excludes the engine from drift-detector reconciliation without affecting runtime availability
  • EngineRegistry — new GetDocumentedEngines() []string returns only engines where IsUserFacingDocumented() == true; this is the set detectors must reconcile against instead of GetSupportedEngines()
  • NewAntigravityEngine() — sets undocumented: true with a comment referencing the maintainer decision history
// pkg/workflow/antigravity_engine.go
BaseEngine{
    id:           "antigravity",
    undocumented: true, // intentionally excluded from engines.md — see gh-aw#47875
    ...
}

Tests: pkg/workflow/spec_test.go

  • TestSpec_Engine_GetDocumentedEngines — asserts antigravity absent from GetDocumentedEngines(), present in GetSupportedEngines()
  • TestSpec_Engine_IsUserFacingDocumented — asserts correct value per engine

Workflow: .github/workflows/daily-doc-updater.md

  • Step 4 — new documented-engines-only rule: before flagging a missing engine row, check grep -r "undocumented:" pkg/workflow/; skip engines with undocumented: true
  • Step 1c — two new guards:
    1. Intentionally-undocumented engine early-exit: if a closed issue concerns an undocumented: true engine, skip unconditionally regardless of closure state
    2. Rejection-awareness: if ≥2 PRs with the same fix direction were closed unmerged, treat the direction as rejected and do not re-attempt without a fresh maintainer decision

Resolves the recurring antigravity engine documentation drift loop
(#47875, escalating #46688) by making the exclusion machine-readable:

Go code:
- Add `undocumented bool` field to `BaseEngine` with explanatory comment
- Add `IsUserFacingDocumented() bool` to the `Engine` interface and
  implement it on `BaseEngine` (returns !undocumented; default true)
- Set `undocumented: true` on AntigravityEngine in NewAntigravityEngine()
  with a comment referencing the maintainer decision and the issue
- Add `GetDocumentedEngines() []string` to EngineRegistry, which filters
  engines by IsUserFacingDocumented() for drift-detector use

Tests (pkg/workflow/spec_test.go):
- TestSpec_Engine_GetDocumentedEngines: asserts antigravity is absent from
  GetDocumentedEngines() and present in GetSupportedEngines()
- TestSpec_Engine_IsUserFacingDocumented: asserts correct value per engine

Workflow (daily-doc-updater.md):
- Step 4: add documented-engines-only rule instructing DDUw to run
  `grep -r "undocumented:" pkg/workflow/` before flagging engine gaps
- Step 1c: add intentionally-undocumented engine early-exit check and
  rejection-awareness guard (skip fix directions with >=2 closed PRs)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix antigravity engine documentation drift issue fix: encode antigravity undocumented intent to break DDUw false-positive loop Jul 25, 2026
Copilot AI requested a review from pelikhan July 25, 2026 00:28
@github-actions

Copy link
Copy Markdown
Contributor

Triage | Category: bug | Risk: medium | Score: 51/100 (impact:25, urgency:15, quality:11)

Recommended action: fast_track — Antigravity false-positive loop fix; modifies workflow engine + lock files. Still draft; needs undraft + CI before merge.

Score breakdown: impact=25 (behavior fix, engine-critical path), urgency=15 (recent, no CI yet), quality=11 (no CI, good description)

Generated by 🔧 PR Triage Agent · sonnet46 · 31.3 AIC · ⌖ 5.51 AIC · ⊞ 5.7K ·

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Great work on this fix! This PR elegantly encodes the antigravity engine's intentional exclusion from user-facing docs into machine-readable form, breaking the 13-issue-in-7-days false-positive loop.

The changes are focused and well-tested:

  • ✅ New IsUserFacingDocumented() interface method lets drift detectors distinguish between supported and documented engines
  • GetDocumentedEngines() on the registry provides the authoritative set for documentation reconciliation
  • ✅ Tests cover both the presence in the supported set and absence in the documented set
  • ✅ Workflow guards prevent re-filing and add rejection-awareness for already-closed fix directions

This PR is ready for review. 🎯

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • patchdiff.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "patchdiff.githubusercontent.com"

See Network Configuration for more information.

Generated by ✅ Contribution Check · sonnet46 · 63.1 AIC · ⌖ 12.1 AIC · ⊞ 6.2K ·

@pelikhan pelikhan closed this Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants