Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions actions/setup/js/write_large_content_to_file.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// @ts-check
/// <reference types="@actions/github-script" />

const fs = require("fs");
const path = require("path");
Expand All @@ -18,7 +17,7 @@ function writeLargeContentToFile(content) {
try {
fs.mkdirSync(logsDir, { recursive: true });
} catch (err) {
throw new Error(`Failed to create directory ${logsDir}: ${String(err)}`, { cause: err });
throw new Error(`Failed to create directory ${logsDir}: ${err.message}`, { cause: err });
}

// Generate SHA256 hash of content
Expand All @@ -31,7 +30,7 @@ function writeLargeContentToFile(content) {
try {
fs.writeFileSync(filepath, content, "utf8");
} catch (err) {
throw new Error(`Failed to write file ${filepath}: ${String(err)}`, { cause: err });
throw new Error(`Failed to write file ${filepath}: ${err.message}`, { cause: err });
}

const description = generateCompactSchema(content);
Expand Down
34 changes: 34 additions & 0 deletions actions/setup/js/write_large_content_to_file.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -228,4 +228,38 @@ describe("writeLargeContentToFile", () => {
expect(result).toHaveProperty("description");
expect(Object.keys(result)).toHaveLength(2);
});

it("should include err.message (not String(err)) in directory creation error", async () => {
const { writeLargeContentToFile } = await import("./write_large_content_to_file.cjs");
const origMkdirSync = fs.mkdirSync;
// @ts-ignore
fs.mkdirSync = () => {
throw new Error("permission denied");
};
try {
const fn = () => writeLargeContentToFile("{}");
expect(fn).toThrow("Failed to create directory");
expect(fn).toThrow(": permission denied");
expect(fn).not.toThrow(": Error: permission denied");
} finally {
fs.mkdirSync = origMkdirSync;
}
});

it("should include err.message (not String(err)) in file write error", async () => {
const { writeLargeContentToFile } = await import("./write_large_content_to_file.cjs");
const origWriteFileSync = fs.writeFileSync;
// @ts-ignore
fs.writeFileSync = () => {
throw new Error("disk full");
};
try {
const fn = () => writeLargeContentToFile("{}");
expect(fn).toThrow("Failed to write file");
expect(fn).toThrow(": disk full");
expect(fn).not.toThrow(": Error: disk full");
} finally {
fs.writeFileSync = origWriteFileSync;
}
});
});
Loading