[WIP] Fix dead Sergo new-linter detector to reference registry.go - #47371
Conversation
PR Triage
Score breakdown: Impact 8/50 · Urgency 12/30 · Quality 8/20 Rationale: WIP draft with 0 file changes — the checklist items are not yet completed. Fixes a dead linter detector to reference the correct file. Low urgency, no CI coverage beyond a single copilot check. Defer until the author completes the checklist and marks ready for review. Labels applied: pr-type:chore · pr-risk:low · pr-priority:low · pr-action:defer · pr-agent:copilot
|
The linter registry authority moved to pkg/linters/registry.go All(). cmd/linters/main.go is now a one-liner (dead for Analyzer counting). - Add `grep -c '.Analyzer,' pkg/linters/registry.go` to sergo bash allowlist - Recompile sergo.lock.yml with updated allowlist Closes #47348 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Attempts to restore Sergo’s linter-registry detector, but the required memory update remains outstanding.
Changes:
- Adds a registry-counting
greppermission. - Regenerates the compiled workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/sergo.md |
Adds the detector command allowlist entry. |
.github/workflows/sergo.lock.yml |
Regenerates compiled workflow metadata and permissions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
| - go list -m all | ||
| - find . -name "*.go" -type f | ||
| - grep -r "func " --include="*.go" | ||
| - grep -c '.Analyzer,' pkg/linters/registry.go |
| - go list -m all | ||
| - find . -name "*.go" -type f | ||
| - grep -r "func " --include="*.go" | ||
| - grep -c '.Analyzer,' pkg/linters/registry.go |
|
🎉 This pull request is included in a new release. Release: |
sergo-stats.jsoninmemory/sergobranch: fixregistry_delta_detectpattern and other stale references to usegrep -c '.Analyzer,' pkg/linters/registry.goinstead ofgrep -c 'Analyzer' cmd/linters/main.gosergo.mdbash tools allowlist to explicitly includegrep -c '.Analyzer,' pkg/linters/registry.gosergo.mdto regeneratesergo.lock.yml