[log] Add debug logging to under-instrumented Go files - #46964
Merged
Conversation
Add namespace-based debug loggers (following the pkg:filename convention from pkg/logger) to five files that previously had no logging but contain real branching/control-flow logic: - cli/bootstrap_profile_git.go: git commit-and-push flow - cli/bootstrap_profile_actions_repo.go: repo variable/secret/copilot-auth actions - cli/bootstrap_profile_helpers.go: value resolution + browser launch - workflow/compiler_yaml_line_writer.go: YAML block-scalar state transitions - console/timezone.go: time-location override handling All log arguments are side-effect-free. Loggers are no-ops unless enabled via the DEBUG environment variable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 21, 2026
Closed
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nAdds structured debug logging to five previously under-instrumented Go files using the existing
pkg/loggerpackage. Each file receives a module-scoped logger instance andPrintf/Printcalls at key execution points to improve observability and debuggability.\n\n### Changed files\n\n| File | Logger tag | Coverage added |\n|------|-----------|----------------|\n|pkg/cli/bootstrap_profile_actions_repo.go|cli:bootstrap_profile_actions_repo| Variable/secret/Copilot auth action entry and skip decisions |\n|pkg/cli/bootstrap_profile_git.go|cli:bootstrap_profile_git| Commit-and-push flow, git command invocations |\n|pkg/cli/bootstrap_profile_helpers.go|cli:bootstrap_profile_helpers| Text value resolution path (env var, non-interactive, default), browser launcher |\n|pkg/console/timezone.go|console:timezone| Timezone override setting, time formatting with configured location |\n|pkg/workflow/compiler_yaml_line_writer.go|workflow:compiler_yaml_line_writer| YAML block scalar state transitions (detect header, enter/leave payload) |\n\n### Pattern applied\n\nEach file follows the same convention already used elsewhere in the codebase:\n\n```go\nvar xyzLog = logger.New(\