Document audit goroutine field-ownership invariants

[Copilot]

auditAnalysisResults is populated from multiple goroutines without synchronization, relying on an implicit invariant that each field has a single writer. This change makes that ownership model explicit at the struct and helper boundaries so future refactors do not accidentally introduce races.

• Concurrency contract on auditAnalysisResults

  • Added a doc comment on auditAnalysisResults describing the lock-free concurrency model.
  • Explicitly states that fields must remain single-writer unless synchronization is introduced.

• Per-helper ownership annotations

  • Added one-line comments to each launch* helper naming the fields it exclusively writes:
    • launchCoreAuditAnalyses
    • launchMetricsAnalysis
    • launchJobDetailsAnalysis
    • launchFirewallAuditAnalyses
    • launchFirewallAnalysis
    • launchSupplementalAuditAnalyses

• Intent made local to the fan-out points

  • Ownership is documented where goroutines are launched, so readers do not need to reconstruct the invariant from closures and setters.

// auditAnalysisResults is populated concurrently during audit collection.
// Each field is written by exactly one goroutine...
type auditAnalysisResults struct {
    metrics          LogMetrics
    failedJobCount   int
    jobDetails       []JobInfoWithDuration
    // ...
}

// launchMetricsAnalysis exclusively writes results.metrics.
func launchMetricsAnalysis(...) { ... }

• Fixes [Code Quality] Document goroutine-safety field-ownership invariants on auditAnalysisResults #46943

[Copilot]

Pull request overview

Documents lock-free field ownership for concurrent audit analysis.

Changes:

• Adds concurrency invariants and helper ownership annotations.
• Includes an unrelated generated workflow behavior change.

Show a summary per file

File	Description
pkg/cli/audit.go	Documents goroutine field ownership.
.github/workflows/smoke-call-workflow.lock.yml	Regenerates inputs, permissions, and secrets unexpectedly.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Medium

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.15