Skip to content

Stabilize Wasm round-trip determinism test by pinning actions/cache/restore to a SHA - #46957

Merged
pelikhan merged 2 commits into
mainfrom
copilot/cgo-fix-workflow-failure-again
Jul 21, 2026
Merged

Stabilize Wasm round-trip determinism test by pinning actions/cache/restore to a SHA#46957
pelikhan merged 2 commits into
mainfrom
copilot/cgo-fix-workflow-failure-again

Conversation

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The CGO test job on main failed in run #18308 due to TestWasmGolden_RoundTrip producing different compiled YAML across repeated compiles. The diff was isolated to uses: actions/cache/restore@... resolving to different pinned forms, breaking the test’s determinism assertion.

  • Root cause

    • TestWasmGolden_RoundTrip used actions/cache/restore@v4 in its inline workflow fixture.
    • Tag-based resolution introduced output variance in CI, so compilation 2 and 3 could differ.
  • Change applied

    • Updated the inline fixture in pkg/workflow/wasm_golden_test.go to use a fixed SHA for actions/cache/restore instead of @v4.
    • This keeps the round-trip test focused on compiler determinism rather than mutable tag-resolution state.
  • Scope

    • Test-only change, limited to a single fixture line in TestWasmGolden_RoundTrip.
    • No production compiler/runtime behavior changes.
# before
uses: actions/cache/restore@v4

# after
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9

Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix workflow failure on main for run #18308 Stabilize Wasm round-trip determinism test by pinning actions/cache/restore to a SHA Jul 21, 2026
Copilot AI requested a review from pelikhan July 21, 2026 04:07
@pelikhan
pelikhan marked this pull request as ready for review July 21, 2026 04:08
Copilot AI review requested due to automatic review settings July 21, 2026 04:08
@pelikhan
pelikhan merged commit 874f5f5 into main Jul 21, 2026
@pelikhan
pelikhan deleted the copilot/cgo-fix-workflow-failure-again branch July 21, 2026 04:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the round-trip test fixture’s cache action to a fixed SHA, preventing mutable tag resolution from affecting determinism checks.

Changes:

  • Replaces actions/cache/restore@v4 with a valid fixed commit SHA.
  • Limits changes to test code.
Show a summary per file
File Description
pkg/workflow/wasm_golden_test.go Stabilizes the Wasm determinism fixture.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CGO] Workflow failure on main - Run #18308

3 participants