Stabilize Wasm round-trip determinism test by pinning actions/cache/restore to a SHA - #46957
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow failure on main for run #18308
Stabilize Wasm round-trip determinism test by pinning Jul 21, 2026
actions/cache/restore to a SHA
pelikhan
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the round-trip test fixture’s cache action to a fixed SHA, preventing mutable tag resolution from affecting determinism checks.
Changes:
- Replaces
actions/cache/restore@v4with a valid fixed commit SHA. - Limits changes to test code.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/wasm_golden_test.go |
Stabilizes the Wasm determinism fixture. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CGO
testjob onmainfailed in run #18308 due toTestWasmGolden_RoundTripproducing different compiled YAML across repeated compiles. The diff was isolated touses: actions/cache/restore@...resolving to different pinned forms, breaking the test’s determinism assertion.Root cause
TestWasmGolden_RoundTripusedactions/cache/restore@v4in its inline workflow fixture.Change applied
pkg/workflow/wasm_golden_test.goto use a fixed SHA foractions/cache/restoreinstead of@v4.Scope
TestWasmGolden_RoundTrip.