enforce mapclearloop in CI linter gates alongside mapdeletecheck - #46413
Merged
Conversation
5 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add mapclearloop to enforced analyzer list
enforce mapclearloop in CI linter gates alongside mapdeletecheck
Jul 18, 2026
pelikhan
marked this pull request as ready for review
July 18, 2026 11:16
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the production-ready mapclearloop analyzer in CI.
Changes:
- Adds
-mapclearloopto production and WASM custom-linter gates.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Enforces mapclearloop alongside mapdeletecheck in both gates. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapclearloopwas absent from the CI enforcement gates despite being production-ready: type-resolved, shadow-safe, comment-safe, and golden-verified withRunWithSuggestedFixes. Its siblingmapdeletecheckwas already enforced, creating an asymmetry where the more carefully guarded analyzer was left out.Changes
.github/workflows/cgo.yml: Add-mapclearloopto bothLINTER_FLAGSinvocations (prod gate and wasm gate), immediately before-mapdeletecheckZero production violations exist today — the only production-adjacent candidate (
pkg/cli/devcontainer.go:316-319) uses a guardedif ... { delete(...) }body, which the analyzer correctly ignores (it requireslen(body.List) == 1with a bare unconditional delete).