-
Notifications
You must be signed in to change notification settings - Fork 429
fix: expand Network Mapping and Pattern Heuristics tables in agentic-workflow-designer SKILL.md #40249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expand Network Mapping and Pattern Heuristics tables in agentic-workflow-designer SKILL.md #40249
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,9 +157,30 @@ Present a structured summary and ask for approval before generation. | |
| | User says... | Maps to | | ||
| |---|---| | ||
| | "calls an external API" | ask for exact FQDN/wildcard, then add to `network.allowed` | | ||
| | "reads GitHub data / clones repos" | include `github` in `network.allowed` | | ||
| | "uses GitHub Actions artifacts or cache" | include `github-actions` in `network.allowed` | | ||
| | "installs npm packages" | include `node` in `network.allowed` | | ||
| | "runs pip install" | include `python` in `network.allowed` | | ||
| | "builds Go code" | include `go` in `network.allowed` | | ||
| | "installs gems / uses Bundler" | include `ruby` in `network.allowed` | | ||
| | "runs cargo build" | include `rust` in `network.allowed` | | ||
| | "uses NuGet / .NET restore" | include `dotnet` in `network.allowed` | | ||
| | "builds with Maven / Gradle" | include `java` in `network.allowed` | | ||
| | "uses Docker / pulls container images / pushes to GHCR" | include `containers` in `network.allowed` | | ||
| | "runs Playwright browser tests" | include `playwright` in `network.allowed` | | ||
| | "runs apt install / yum / apk" | include `linux-distros` in `network.allowed` | | ||
| | "uses Terraform / HashiCorp registry" | include `terraform` in `network.allowed` | | ||
| | "connects to localhost / loopback / local services" | include `local` in `network.allowed` | | ||
| | "uses Swift Package Manager" | include `swift` in `network.allowed` | | ||
| | "uses Composer / PHP packages" | include `php` in `network.allowed` | | ||
| | "uses pub.dev / Dart packages" | include `dart` in `network.allowed` | | ||
| | "uses Hackage / Haskell packages" | include `haskell` in `network.allowed` | | ||
| | "uses CPAN / Perl packages" | include `perl` in `network.allowed` | | ||
| | "serves or loads web fonts" | include `fonts` in `network.allowed` | | ||
| | "uses Deno or JSR packages" | include `deno` in `network.allowed` | | ||
| | "uses Elixir / Hex packages" | include `elixir` in `network.allowed` | | ||
| | "uses Bazel build" | include `bazel` in `network.allowed` | | ||
| | "uses R / CRAN packages" | include `r` in `network.allowed` | | ||
| | "no external access" | `network.allowed: [defaults]` (or `[]` if explicitly zero network) | | ||
|
|
||
|
|
||
| ### Tool Mapping | ||
|
|
@@ -184,6 +205,19 @@ Present a structured summary and ask for approval before generation. | |
| | "monitor workflow failures and trends" | `MonitorOps` | | ||
| | "process a big backlog in chunks" | `BatchOps` | | ||
| | "run manually with input parameters" | `DispatchOps` | | ||
| | "apply a label-based workflow" | `LabelOps` | | ||
| | "operate across multiple repositories" | `MultiRepoOps` | | ||
| | "coordinate multiple sub-agents" | `Orchestration` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrong pattern name: 💡 Suggested fixBoth pattern doc files ( -| "coordinate multiple sub-agents" | `Orchestration` |
+| "coordinate multiple sub-agents" | `OrchestratorOps` |Apply the same fix to |
||
| | "manage project board items" | `ProjectOps` | | ||
| | "research, plan, and assign issues" | `ResearchPlanAssignOps` | | ||
| | "self-correcting / retry on failure" | `CorrectionOps` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs] The trigger phrase
A user describing "self-correcting / retry on failure" behaviour would be incorrectly routed to 💡 Suggested fixAlign the phrase with the actual pattern intent: -| "self-correcting / retry on failure" | `CorrectionOps` |
+| "learn from human corrections without retraining" | `CorrectionOps` |If retry-on-failure routing is also needed, add a separate row pointing to an appropriate pattern (e.g. |
||
| | "run in a side/fork repo" | `SideRepoOps` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs]
💡 Suggested fix-| "run in a side/fork repo" | `SideRepoOps` |
+| "run automation from a companion/satellite repository" | `SideRepoOps` | |
||
| | "write a spec before implementing" | `SpecOps` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs]
💡 Suggested fix-| "write a spec before implementing" | `SpecOps` |
+| "maintain a formal spec and propagate updates to implementations" | `SpecOps` | |
||
| | "A/B test workflow variants" | `TrialOps` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs]
💡 Suggested fix-| "A/B test workflow variants" | `TrialOps` |
+| "validate in an isolated trial repo before production" | `TrialOps` |
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trigger phrase mismatches pattern purpose: 💡 Details and suggested fixThe TrialOps docs describe a A user asking to "A/B test workflow variants" will be steered to TrialOps when they likely need A/B Experiments or simply want to run two different workflows side-by-side. Suggested trigger phrase that actually describes TrialOps: -| "A/B test workflow variants" | `TrialOps` |
+| "validate a workflow in an isolated test repo before deploying" | `TrialOps` |Apply the same fix to |
||
| | "process items from a queue" | `WorkQueueOps` | | ||
| | "deterministic, no LLM needed" | `DeterministicOps` | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs] The trigger phrase
💡 Suggested fix-| "deterministic, no LLM needed" | `DeterministicOps` |
+| "deterministic data collection + agentic analysis" | `DeterministicOps` |For users who truly want no LLM, the correct answer is a plain GitHub Actions workflow — not a pattern in this guide at all. |
||
| | "manage from a central repo" | `CentralRepoOps` | | ||
| | "track work via GitHub Projects" | `Monitoring with Projects` | | ||
|
|
||
| ### Integration Auth Mapping | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] 14 ecosystem identifiers from
network.mdare still absent from this table after the expansion.The PR description claims to cover "all high-frequency ecosystem identifiers plus additional long-tail ones", but
network.mdlists 39 identifiers total and the SKILL.md now covers 26 — leaving these still unmapped:clojure,julia,kotlin,lua,node-cdns,ocaml,powershell,scala,zig,dev-tools,chrome,latex,lean,python-nativeSome of these (
node-cdns,dev-tools,chrome,powershell,kotlin) are plausible choices in CI/CD workflows.💡 Suggested additions
High-priority missing entries:
node-cdnsinnetwork.alloweddev-toolsinnetwork.allowedchromeinnetwork.allowedpowershellinnetwork.allowedkotlininnetwork.allowedOr, if the intent is intentional curation rather than exhaustive coverage, update the PR description to say so.