Skip to content

fix: disable LFS checkout in docs build and unbloat-docs AW#39942

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/update-docs-build-to-ignore-lfs
Closed

fix: disable LFS checkout in docs build and unbloat-docs AW#39942
Copilot wants to merge 3 commits into
mainfrom
copilot/update-docs-build-to-ignore-lfs

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

git lfs fetch was failing with exit code 2 on CI runners (run), blocking the unbloat-docs AW before the agent could start. The repo has LFS-tracked slide assets (docs/slides/**) but neither the Astro docs build nor the unbloat AW need them.

Changes

  • .github/workflows/unbloat-docs.mdlfs: truelfs: false in checkout step; recompiled lock file
  • .github/workflows/docs.yml — same fix in the regular doc build/deploy workflow

Copilot AI and others added 2 commits June 18, 2026 01:16
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title fix: disable LFS in docs build and unbloat-docs AW fix: disable LFS checkout in docs build and unbloat-docs AW Jun 18, 2026
Copilot AI requested a review from pelikhan June 18, 2026 01:20
@pelikhan pelikhan marked this pull request as ready for review June 18, 2026 01:35
Copilot AI review requested due to automatic review settings June 18, 2026 01:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables Git LFS checkout in the docs build and the documentation “unbloat” agentic workflow to prevent CI failures from git lfs fetch when LFS-tracked slide assets aren’t needed for these jobs.

Changes:

  • Turn off lfs in the docs deployment workflow checkout step.
  • Turn off lfs in the unbloat-docs workflow checkout step and recompile the corresponding lock file.
  • Update the setup-cli install script header comment (but it now reads self-referential/ambiguous).
Show a summary per file
File Description
actions/setup-cli/install.sh Updates the header sync note (currently ambiguous/self-referential).
.github/workflows/unbloat-docs.md Disables LFS during checkout for the unbloat-docs workflow.
.github/workflows/unbloat-docs.lock.yml Regenerated compiled workflow to reflect lfs: false.
.github/workflows/docs.yml Disables LFS during checkout for the docs build/deploy workflow.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 1

Comment thread actions/setup-cli/install.sh Outdated
set +o histexpand

# Kept in sync with install-gh-aw.sh — edit that file, then copy to this path.
# Kept in sync with actions/setup-cli/install.sh — edit this file, then copy to that path.
@github-actions

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — nice targeted fix for the git lfs fetch failure blocking the unbloat-docs AW! The root cause is clearly explained and the change is minimal and surgical.

One small thing to address:

  • actions/setup-cli/install.sh is not mentioned in the PR body — this file has a 1-line change but isn't described in the Changes section. Even a brief note like install.sh — removed lfs dependency would make the diff fully self-explanatory for reviewers.

  • No test coverage — workflow YAML changes can't be unit-tested, but the PR references a specific failing CI run as evidence. Consider adding a brief note in the body confirming the fix was validated (e.g., "Verified locally" or linking to a green run post-fix) so reviewers have a clear signal that this resolves the issue.

If you'd like a hand tidying up:

Update the PR body for github/gh-aw#39942 to:
1. Add a mention of the `actions/setup-cli/install.sh` change under the ## Changes section, explaining what was changed and why.
2. Add a ## Verification section noting how the fix was validated (e.g., link to a passing CI run or describe the manual test performed).

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • patchdiff.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "patchdiff.githubusercontent.com"

See Network Configuration for more information.

Generated by ✅ Contribution Check ·

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

…uild-to-ignore-lfs

# Conflicts:
#	actions/setup-cli/install.sh

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot merge main and recompile

Done — merged origin/main (resolved one conflict in actions/setup-cli/install.sh by keeping the correct sync comment from main) and recompiled all workflows. No lock file changes were needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants