fix: remove dispatch-repository dash alias from parser

[Copilot]

parseDispatchRepositoryConfig accepted both dispatch_repository and dispatch-repository, but the safe-output schema only declared the underscore form — creating a silent parser-vs-schema gap where the dash form would parse but fail schema validation.

Changes

• pkg/workflow/dispatch_repository.go: Drop the dispatch-repository fallback lookup; only dispatch_repository is now accepted.
• pkg/workflow/dispatch_repository_test.go: Remove TestParseDispatchRepositoryConfig_DashAlias which covered the removed behaviour.

[github-actions]

Hey @Copilot 👋 — thanks for picking up the dispatch-repository schema consistency fix from issue #39599! The scope is clear and well-grounded. A couple of things to sort out before this is ready for review:

• Misaligned title/direction — the PR title says "Add dispatch-repository dash alias to safe-output schema", but @pelikhan's comment redirects to "remove support parsing dispatch-repository with dash" from the parser. These are opposite changes. Once the implementation is committed, the title (and body) should reflect the actual direction taken.
• No code changes yet — the PR is a WIP draft with 0 changed files. When the implementation lands, reviewers will need to see the actual schema/parser edits.
• Tests — the parser change (removing dash alias support in parseDispatchRepositoryConfig) should include a test case covering a workflow that uses dispatch-repository to confirm it is now rejected, and one confirming dispatch_repository continues to work.

If you'd like a hand completing the implementation, here's a ready-to-use prompt:

In pkg/workflow/dispatch_repository.go, remove support for the dash-alias form `dispatch-repository`:
1. In parseDispatchRepositoryConfig (around line 30), delete the branch that accepts "dispatch-repository" as an alias, keeping only "dispatch_repository".
2. Update pkg/parser/schemas/main_workflow_schema.json if it currently lists "dispatch-repository" — remove any reference to the dash form.
3. Add a parser test that confirms a workflow using the key `dispatch-repository` now fails validation, and a test confirming `dispatch_repository` still passes.
4. Update the PR title to: "Remove dash-alias dispatch-repository from parser".

Generated by ✅ Contribution Check · ◷

[Copilot]

⚠️ Not ready to approve

A small regression test should be added to assert the dash-form key is now rejected, so the behavior change is protected against accidental reintroduction.

Pull request overview

This PR removes support for the dispatch-repository (dash) alias in parseDispatchRepositoryConfig, so the parser only accepts dispatch_repository (underscore) and stays consistent with the safe-outputs schema.

Changes:

• Removed the dispatch-repository fallback lookup so only dispatch_repository is recognized.
• Removed the unit test that previously asserted the dash alias was accepted.

File summaries

File	Description
pkg/workflow/dispatch_repository.go	Drops the dash-key fallback so parsing matches the schema’s underscore-only key.
pkg/workflow/dispatch_repository_test.go	Removes the dash-alias acceptance test (and leaves room for a replacement “rejected” test).

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

@copilot review all comments and address unresolved review feedback for this PR.

Generated by 👨‍🍳 PR Sous Chef · ◷