Add formal AWF config source conformance test suite (P1–P10)

[Copilot]

This change codifies the specs/awf-config-sources-spec.md conformance model into executable tests so AWF config canonicalization behavior is checked against the formal requirements (dual-source consultation, drift semantics, SLA/escalation, and degraded-mode safeguards). It adds the expected P1–P10 coverage as a dedicated formal suite under pkg/workflow.

• Formal conformance suite (pkg/workflow/awf_config_drift_formal_test.go)

  • Adds 10 testify tests mapped 1:1 to the spec predicates:
    • DualSourceConsultation (CR-01)
    • NoUndocumentedFieldGeneration (CR-03)
    • DriftRecordStructuralValidity (§4.5.1)
    • DriftCategoryExhaustiveness (§4.5.1)
    • SchemaOnlyPropertyFlaggedAsDrift (CR-02)
    • CorrectionPRForActionableDrift (CR-05)
    • SLARemediationWindow (CR-06)
    • EscalationIssueStructure (CR-06a)
    • SafeguardDegradedModeOnUnavailability (§5)
    • DriftReportEmittedOnDetection (§4.2)

• Spec-aligned formal helpers (test-local)

  • Introduces small test-only model helpers for:
    • drift record structural validation and category enum enforcement
    • schema-vs-coverage drift emission
    • corrective-PR obligation checks for actionable categories
    • business-day deadline arithmetic for 5-day SLA windows
    • escalation issue minimal-structure checks
    • degraded-mode state expectations when canonical sources are unavailable

• Example (predicate mapping and intent)

  func TestFormal_P7_SLARemediationWindow(t *testing.T) {
  	detected := time.Date(2026, 6, 8, 9, 0, 0, 0, time.UTC) // Monday
  	deadline := formalAddBusinessDays(detected, 5)
  
  	assert.Equal(t, time.Date(2026, 6, 15, 9, 0, 0, 0, time.UTC), deadline)
  	assert.True(t, formalSLARemediationWindow(detected, deadline))
  	assert.False(t, formalSLARemediationWindow(detected, deadline.Add(time.Second)))
  }

[pelikhan]

@copilot run pr-finisher skill

[Copilot]

Pull request overview

This PR adds a new “formal” Go test suite intended to codify the conformance predicates described in specs/awf-config-sources-spec.md (P1–P10) so AWF config drift/canonicalization expectations are validated in CI.

Changes:

• Adds pkg/workflow/awf_config_drift_formal_test.go with 10 tests named TestFormal_P1 … TestFormal_P10.
• Introduces test-local helper predicates (dual-source consultation, drift record structure/category, SLA business-day arithmetic, escalation issue structure, degraded-mode safeguards, drift report emission).

Show a summary per file

File	Description
pkg/workflow/awf_config_drift_formal_test.go	Adds a new formal conformance test suite and helper predicates for AWF config drift requirements.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 4

[Copilot]

@copilot run pr-finisher skill

Ran the pr-finisher workflow and pushed 5c05807, which fixes the PR-owned lint failure in pkg/workflow/awf_config_drift_formal_test.go (assert.Len(..., 0) → assert.Empty(...)). I also ran fmt/lint/test-unit/test and inspected failing CI logs; remaining failures are unrelated baseline issues outside this PR’s changed file.