Skip to content

fix: update pinned commit SHA in dispatch-workflow integration test to use cli-proxy #28958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 28, 2026
Merged

fix: update pinned commit SHA in dispatch-workflow integration test to use cli-proxy #28958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52d5b3
Initial plan
Copilot Apr 28, 2026
495db82
fix: update pinned commit SHA in dispatch-workflow integration test t…
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"private": true,
"license": "MIT",
"dependencies": {
"@sentry/mcp-server": "0.32.0"
"@sentry/mcp-server": "0.33.0"

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency bump is not mentioned in the PR description, which focuses on updating the pinned workflow commit SHA for an integration test. Either include a short rationale in the PR description for this version update or move it to a separate PR to keep the change focused.

Copilot uses AI. Check for mistakes.
}
}
8 changes: 5 additions & 3 deletions pkg/cli/add_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,10 +1023,12 @@ func TestAddWorkflowWithDispatchWorkflowFromSharedImport(t *testing.T) {
// workflow and the dispatch-workflow dependency are written to disk.
//
// Note: pinned to a specific commit SHA that includes strict: false in smoke-copilot.md
// (required since sandbox.mcp.container is now blocked in strict mode) and
// (required since sandbox.mcp.container is now blocked in strict mode),
// serena-go.md uses ./serena.md (explicitly-relative) so the fetcher correctly
// resolves it against shared/mcp/ rather than the top-level .github/workflows/.
workflowSpec := "github/gh-aw/.github/workflows/smoke-copilot.md@a4237ca"
// resolves it against shared/mcp/ rather than the top-level .github/workflows/,
// and tools.cli-proxy: true (not the deprecated mount-as-clis which was removed from

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references tools.cli-proxy: true, while the PR description states the replacement field is cli-proxy: true. To avoid misleading future readers, align the comment with the actual schema/property name used by smoke-copilot.md (and keep it consistent with the PR description).

Suggested change
// and tools.cli-proxy: true (not the deprecated mount-as-clis which was removed from
// and cli-proxy: true (not the deprecated mount-as-clis which was removed from

Copilot uses AI. Check for mistakes.
// the schema when the mount-as-clis-to-cli-proxy codemod was added).
workflowSpec := "github/gh-aw/.github/workflows/smoke-copilot.md@d555622"

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned ref uses a short (7-char) commit SHA. For long-term stability in tests, prefer pinning to a longer SHA (commonly 12+) or the full 40-char SHA to minimize the risk of future ambiguity/collision as the upstream repo grows.

Suggested change
workflowSpec := "github/gh-aw/.github/workflows/smoke-copilot.md@d555622"
workflowSpec := "github/gh-aw/.github/workflows/smoke-copilot.md@<FULL_40_CHARACTER_SHA_FOR_D555622>"

Copilot uses AI. Check for mistakes.

cmd := exec.Command(setup.binaryPath, "add", workflowSpec, "--verbose")
cmd.Dir = setup.tempDir
Expand Down
Loading