Skip to content

fix: move protected files details section inside alert block #23702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Mar 31, 2026
Merged

fix: move protected files details section inside alert block #23702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions actions/setup/md/manifest_protection_create_pr_fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
> This was originally intended as a pull request, but the patch modifies protected files. These files may affect project dependencies, CI/CD pipelines, or agent behaviour. **Please review the changes carefully** before creating the pull request.
>
> **[Click here to create the pull request once you have reviewed the changes]({create_pr_url})**

<details>
<summary>Protected files</summary>

{files}

</details>
>
> <details>
> <summary>Protected files</summary>
>
> {files}

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{files} is a newline-joined list, but in this quoted alert only the first line is prefixed with >. If more than one protected file is present, the extra lines will render outside the warning callout. Recommend passing an already-quoted {files} value (prefix each line with > ) or changing {files} to a single-line HTML list so the entire file list stays inside the alert/details block.

Suggested change
> {files}
{files}

Copilot uses AI. Check for mistakes.
>
> </details>

To route changes like this to a review issue instead of blocking, configure `protected-files: fallback-to-issue` in your workflow configuration.

Expand Down
18 changes: 9 additions & 9 deletions actions/setup/md/manifest_protection_push_failed_fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
> **Protected Files — Push Permission Denied**
>
> This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

<details>
<summary>Protected files</summary>

{files}

The push was rejected because GitHub Actions does not have `workflows` permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

</details>
>
> <details>
> <summary>Protected files</summary>
>
> {files}
>
> The push was rejected because GitHub Actions does not have `workflows` permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.
Comment on lines +10 to +15

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{files} expands to multiple lines (newline-separated Markdown list). With the current template, only the first line is blockquoted (> {files}), so subsequent lines will escape the [!WARNING] alert and won’t appear inside this <details> section. Suggest adjusting the renderer to prefix every line with > (or switch {files} to an HTML representation that doesn’t rely on newlines).

Copilot uses AI. Check for mistakes.
>
> </details>

<details>
<summary><b>Create the pull request manually</b></summary>
Expand Down
14 changes: 7 additions & 7 deletions actions/setup/md/manifest_protection_push_to_pr_fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
> **Target Pull Request:** [#{pull_number}]({pr_url})
>
> **Please review the changes carefully** before pushing them to the pull request branch. These files may affect project dependencies, CI/CD pipelines, or agent behaviour.

<details>
<summary>Protected files</summary>

{files}

</details>
>
> <details>
> <summary>Protected files</summary>
>
> {files}
Comment on lines +12 to +13

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{files} is rendered from buildProtectedFileList() as a newline-separated Markdown list. In this blockquote/alert context only the first line is prefixed with >, so any additional list items will render outside the warning callout (and may also break the <details> body). Consider passing a pre-quoted variant (e.g., replace \n with \n> before rendering) or emitting the file list as single-line HTML (e.g., <ul><li>…</li></ul> or <br>-separated) so all items stay inside the alert.

Suggested change
>
> {files}
>
> ```text
> {files}
> ```

Copilot uses AI. Check for mistakes.
>
> </details>

---

Expand Down
Loading