Remove duplicate TLS declarations in internal/httputil

[Copilot]

internal/httputil contained two copies of the same TLS helpers and tests, causing package-level redeclaration errors and preventing the package from compiling. This change consolidates the package back to a single implementation and a single test file.

• Remove duplicate package declarations

  • Delete internal/httputil/tls_config.go
  • Keep internal/httputil/tls.go as the single source of truth for:
    • MinTLSVersion
    • NewServerTLSConfig
    • NewClientTLSConfig

• Collapse duplicate tests

  • Delete internal/httputil/tls_config_test.go
  • Preserve the only distinct assertion from the duplicate test file by adding assert.NotNil checks to internal/httputil/tls_test.go

• Resulting package shape

  • One implementation file defines the TLS defaults
  • One test file validates the server and client helpers without duplicate symbols

func TestNewServerTLSConfig(t *testing.T) {
	cert := tls.Certificate{Certificate: [][]byte{[]byte("leaf-cert")}}

	cfg := NewServerTLSConfig(cert)

	assert.NotNil(t, cfg)
	assert.EqualValues(t, MinTLSVersion, cfg.MinVersion)
	assert.Len(t, cfg.Certificates, 1)
	assert.Equal(t, cert, cfg.Certificates[0])
}

[Copilot]

Pull request overview

This PR fixes internal/httputil build failures caused by duplicate TLS helper and test declarations by consolidating the package back to a single implementation (tls.go) and a single test file (tls_test.go).

Changes:

• Remove the duplicate TLS helper implementation by deleting internal/httputil/tls_config.go.
• Remove the duplicate TLS tests by deleting internal/httputil/tls_config_test.go.
• Preserve the only distinct assertion from the duplicate tests by adding assert.NotNil checks to internal/httputil/tls_test.go.

Show a summary per file

File	Description
internal/httputil/tls_test.go	Adds missing assert.NotNil coverage for the returned TLS configs to retain the unique assertion from the deleted duplicate test file.
internal/httputil/tls_config.go	Deletes the redundant TLS helper definitions that caused package-level redeclaration errors.
internal/httputil/tls_config_test.go	Deletes the redundant TLS test file to eliminate duplicate test symbol definitions.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 0