Add debug instrumentation to mcpresult content parsing and extraction

[Copilot]

The Go Logger Enhancement workflow run failed before it could open a PR, leaving the intended mcpresult logging updates unapplied. This PR applies that missing enhancement directly in code with minimal scope.

• What changed

  • Added a package logger in internal/mcpresult/mcpresult.go:
    • var logMCPResult = logger.New("mcpresult:mcpresult")
  • Added debug logs around key decision points in:
    • NormalizeContentItems (input type, normalization path, item counts, unsupported type)
    • ExtractTextContent (content presence, normalization failure path, item processing count, output length)

• Behavioral intent

  • Improves observability of MCP tool-result parsing/extraction paths without altering return semantics.
  • Keeps logging side-effect free and aligned with existing logger.New("pkg:filename") conventions.

• Test update after review feedback

  • Removed TestExtractTextContent_WithDebugLoggingEnabled from internal/mcpresult/text_content_test.go because per-test t.Setenv("DEBUG", ...) cannot reconfigure the already-initialized package logger and the test was misleading.

var logMCPResult = logger.New("mcpresult:mcpresult")

func NormalizeContentItems(contentVal interface{}) ([]map[string]interface{}, bool) {
    logMCPResult.Printf("Normalizing MCP content items from type %T", contentVal)
    // ...
}

[Copilot]

Pull request overview

This PR adds debug-level instrumentation to the internal/mcpresult helpers used to normalize MCP “content” arrays and extract concatenated text, aiming to improve observability of tool-result parsing without changing behavior.

Changes:

• Added a package-scoped debug logger (logMCPResult) to internal/mcpresult/mcpresult.go.
• Emitted debug logs at key decision points in NormalizeContentItems and ExtractTextContent.
• Added a new unit test intended to validate extraction behavior with debug logging enabled.

Show a summary per file

File	Description
internal/mcpresult/mcpresult.go	Adds a namespace-scoped debug logger and instrumentation around content normalization/text extraction paths.
internal/mcpresult/text_content_test.go	Adds a new test case that sets DEBUG=mcpresult:* and validates extraction output.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1

[lpcox]

@copilot address review feedback

[Copilot]

@copilot address review feedback

Addressed in 9b3d352. I removed TestExtractTextContent_WithDebugLoggingEnabled from internal/mcpresult/text_content_test.go since t.Setenv("DEBUG", ...) cannot affect the already-initialized package logger and the test was misleading.