Skip to content

docs: document MCP_GATEWAY_SHUTDOWN_TIMEOUT environment variable#7683

Merged
lpcox merged 2 commits into
mainfrom
copilot/fix-missing-env-var-documentation
Jun 17, 2026
Merged

docs: document MCP_GATEWAY_SHUTDOWN_TIMEOUT environment variable#7683
lpcox merged 2 commits into
mainfrom
copilot/fix-missing-env-var-documentation

Conversation

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

MCP_GATEWAY_SHUTDOWN_TIMEOUT was implemented in internal/cmd/flags_serve.go (controls --shutdown-timeout, default 5s) but absent from all documentation, making it undiscoverable for operators needing to tune graceful shutdown for long-running tool calls.

Changes

  • docs/ENVIRONMENT_VARIABLES.md — Added row to the "Optional (Non-Containerized Mode)" table, grouped with other timeout variables between MCP_GATEWAY_SESSION_TIMEOUT and MCP_GATEWAY_TOOL_TIMEOUT
  • AGENTS.md — Added bullet entry in the Environment Variables section at the same relative position

Copilot AI changed the title [WIP] Fix missing documentation for MCP_GATEWAY_SHUTDOWN_TIMEOUT docs: document MCP_GATEWAY_SHUTDOWN_TIMEOUT environment variable Jun 17, 2026
GitHub Advanced Security finished work on behalf of lpcox June 17, 2026 14:10
Copilot AI requested a review from lpcox June 17, 2026 14:10
Copilot finished work on behalf of lpcox June 17, 2026 14:10
GitHub Advanced Security started work on behalf of lpcox June 17, 2026 14:11 View session
GitHub Advanced Security finished work on behalf of lpcox June 17, 2026 14:13
@lpcox lpcox marked this pull request as ready for review June 17, 2026 14:52
Copilot AI review requested due to automatic review settings June 17, 2026 14:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the previously implemented MCP_GATEWAY_SHUTDOWN_TIMEOUT environment variable so operators can discover and tune the gateway’s graceful shutdown behavior (the env var provides the default for --shutdown-timeout, which is used by the shared HTTP server lifecycle code).

Changes:

  • Added MCP_GATEWAY_SHUTDOWN_TIMEOUT to the environment variables reference with default 5s and Go-duration examples.
  • Added the same variable to AGENTS.md to keep the operator/agent quick reference in sync.
Show a summary per file
File Description
docs/ENVIRONMENT_VARIABLES.md Adds the missing MCP_GATEWAY_SHUTDOWN_TIMEOUT entry to the main env var reference table near other timeout settings.
AGENTS.md Adds a corresponding bullet under Environment Variables to keep AGENTS.md consistent with the docs reference.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lpcox lpcox merged commit 3fbdce6 into main Jun 17, 2026
40 checks passed
@lpcox lpcox deleted the copilot/fix-missing-env-var-documentation branch June 17, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants